Skip to content

[UniformTypeIdentifiers] Add support for Xcode 14 beta 1, 2 & 3 #15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

[UniformTypeIdentifiers] Add support for Xcode 14 beta 1, 2 & 3 #15550

merged 1 commit into from
Jul 20, 2022

Conversation

@mandel-macaque
Copy link
Contributor

@mandel-macaque mandel-macaque commented Jul 19, 2022

No description provided.

@mandel-macaque mandel-macaque added the notes-mention Deserves a mention in release notes label Jul 19, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 20, 2022

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8372a352977ece21ba57c0abb1b63eb8de85ecce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 20, 2022

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1167.Monterey'
Hash: 8372a352977ece21ba57c0abb1b63eb8de85ecce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 20, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 8372a352977ece21ba57c0abb1b63eb8de85ecce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 20, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 8372a352977ece21ba57c0abb1b63eb8de85ecce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 20, 2022

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 225 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests/NUnit: Failed (Execution failed with exit code 3)

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 1 tests passed.
  • Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque mandel-macaque merged commit aaa2640 into dotnet:xcode14 Jul 20, 2022
@mandel-macaque mandel-macaque deleted the uniformtypeidentifiers-xcode14 branch July 20, 2022 12:25
SotoiGhost
SotoiGhost reviewed Jul 22, 2022
View reviewed changes
src/foundation.cs

[Watch (9,0), TV (16,0), Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
[Export ("loadFileRepresentationForContentType:openInPlace:completionHandler:")]
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler);
Copy link
Contributor

@SotoiGhost SotoiGhost Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completionHandler has a wrong signature. You could reuse LoadInPlaceFileRepresentationHandler but it has one different param name:

Suggested change
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler);
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, LoadInPlaceFileRepresentationHandler completionHandler);

or create a new handler with right param names:

Suggested change
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler);
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, LoadFileRepresentationHandler completionHandler);
[Watch (9,0), TV (16,0), Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
delegate void LoadFileRepresentationHandler (NSUrl fileUrl, bool openInPlace, NSError error);

@SotoiGhost
Copy link
Contributor

SotoiGhost commented Jul 22, 2022

hmm... it seems I didn't refresh the page, didn't notice that this was merged. I'll create a new PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

@chamons chamons Awaiting requested review from chamons

+1 more reviewer

@SotoiGhost SotoiGhost SotoiGhost left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

notes-mention Deserves a mention in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @SotoiGhost @dalexsoto